fix: some of the model settings are not applied #5644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 7b22ba8 in 1 minute and 24 seconds. Click for details.
- Reviewed
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_khCKgKtAPCFqo3xP
You can customize 
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed db74f2c in 1 minute and 20 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_CQZmB3XYJLzXT37Y
You can customize
urmauur
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR aims to ensure that all model settings are sent to the llama.cpp server. In this patch, we'll apply a very minimal validation to avoid potential issues. Any enhancements should be submitted to the llama.cpp extension Epic.
With some of parameters disabled (leave empty)
With value inputed
Fixes Issues
Self Checklist
Important
Fixes issue where some model settings were not applied by converting specific parameters to float in
normalizeValue()inutils.ts.normalizeValue()inutils.tsto convert specific parameters to float.normalizeValue()to handletemperature,top_k,top_p,min_p,repeat_penalty,frequency_penalty,presence_penalty,repeat_last_nas floats.validationRulesinextractInferenceParams()andextractModelLoadParams()to validate and normalize parameters.This description was created by
for db74f2c. You can customize this summary. It will automatically update as commits are pushed.